Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): update docs to React 18 #3398

Merged
merged 6 commits into from
Jun 20, 2023
Merged

chore(docs): update docs to React 18 #3398

merged 6 commits into from
Jun 20, 2023

Conversation

joshblack
Copy link
Member

With our move to React 18 in v36, this PR updates the docs site to use React 18. Currently, this work is targeting main and this could then be merged into next-major. However, if folks feel more confident putting it in next-major directly just let me know! Happy to change the base branch 👀

Testing & Reviewing

  • This makes changes to React in our docs site so I'd appreciate any and all help testing out the deploy preview for the docs page here to make sure no regressions occur 🙏

@joshblack joshblack requested review from a team and siddharthkp June 9, 2023 16:55
@changeset-bot
Copy link

changeset-bot bot commented Jun 9, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3316c6b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joshblack joshblack added the skip changeset This change does not need a changelog label Jun 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023 •
edited
Loading

size-limit report 📦

Path Size
dist/browser.esm.js 101.01 KB (0%)
dist/browser.umd.js 101.57 KB (0%)

@joshblack joshblack temporarily deployed to github-pages June 9, 2023 17:01 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3398 June 9, 2023 17:01 Inactive
@radglob
Copy link
Contributor

radglob commented Jun 9, 2023

Glad it was only a few small changes. I think it probably makes sense to just merge this into next-major. I don't think there's any pressing reason for it to go into main, and there aren't compatibility issues there as far as I'm aware.

@radglob radglob mentioned this pull request Jun 14, 2023
Merged
7 tasks
@joshblack joshblack enabled auto-merge June 19, 2023 15:58
@joshblack joshblack temporarily deployed to github-pages June 19, 2023 16:04 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3398 June 19, 2023 16:05 Inactive
@joshblack joshblack temporarily deployed to github-pages June 19, 2023 16:16 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3398 June 19, 2023 16:16 Inactive
@radglob radglob temporarily deployed to github-pages June 20, 2023 13:44 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3398 June 20, 2023 13:44 Inactive
@radglob radglob temporarily deployed to github-pages June 20, 2023 14:28 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3398 June 20, 2023 14:29 Inactive
@joshblack joshblack added this pull request to the merge queue Jun 20, 2023
Merged via the queue into main with commit 4a0ea78 Jun 20, 2023
@joshblack joshblack deleted the chore/update-docs-site-to-react-18 branch June 20, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mperrotti mperrotti mperrotti approved these changes

@radglob radglob radglob approved these changes

@siddharthkp siddharthkp Awaiting requested review from siddharthkp

Assignees
No one assigned
Labels
skip changeset This change does not need a changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshblack @radglob @mperrotti